Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move from defaultClusterIssuer due to main reference #17

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

mliner
Copy link
Contributor

@mliner mliner commented Jul 23, 2024

Description

This change finally fixes the issue with defaultClusterIssuer referring to main branch as the source for helm chart. We are going to slowly discontinue this issuer by duplicating the chart with different name as clusterIssuer and updating the release process so there is always reference to specific version of helm chart.

Added decomision note into readme.

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

How Has This Been Tested?

@mliner mliner requested a review from jaygridley July 23, 2024 10:56
@mliner mliner force-pushed the fix-default-issuer branch from a35c27e to c33bc9c Compare July 23, 2024 12:36
@mliner mliner marked this pull request as ready for review July 23, 2024 12:36
@mliner mliner force-pushed the fix-default-issuer branch from c33bc9c to 00a517a Compare July 23, 2024 12:41
Copy link
Member

@jaygridley jaygridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mliner mliner changed the title Fix default issuer fix: moved from defaultClusterIssuer due to main reference Jul 23, 2024
@mliner mliner changed the title fix: moved from defaultClusterIssuer due to main reference fix: move from defaultClusterIssuer due to main reference Jul 23, 2024
@mliner mliner merged commit 87f6476 into main Jul 23, 2024
5 checks passed
@mliner mliner deleted the fix-default-issuer branch July 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants