Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elixir WebRTC - Nexus app demo to docs #162

Closed
wants to merge 1 commit into from
Closed

Conversation

Megzo
Copy link
Contributor

@Megzo Megzo commented Sep 25, 2024

I created a new demo description to showcase how to use STUNner with Elixir WebRTC.
Please check if everything works correctly ;)

@levaitamas levaitamas added the type: documentation Doc extension label Sep 25, 2024
Copy link
Member

@levaitamas levaitamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for taking care of the README and readthedocs links. Aside from some minor typos, it looks good to me.

until [ -n "$(kubectl get svc udp-gateway -n stunner -o jsonpath='{.status.loadBalancer.ingress[0].ip}')" ]; do sleep 1; done
export STUNNERIP=$(kubectl get service udp-gateway -n stunner -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
```
### Nexus ocker images
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocker -> Docker


Now rebuild the Docker image, and push it into your image repository:
```
export MYREPO=myrepo # use you'r own Docker repository name!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'r -> your

@rg0now
Copy link
Member

rg0now commented Sep 27, 2024

Thanks, this is really cool! I think if we just fix the typos this can be merged as is and so it can make it into v1. I'll add Elixir to the release notes.

@davidkornel davidkornel mentioned this pull request Oct 15, 2024
7 tasks
davidkornel added a commit that referenced this pull request Oct 16, 2024
@levaitamas
Copy link
Member

closing this in favor of #164

@levaitamas levaitamas closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Doc extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants