-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I added support for sending PMS5003 measurements to domoticz #1
base: master
Are you sure you want to change the base?
Conversation
Hi, Thanks for doing this, looks like a useful addition. A few remarks though:
Also, the cli interface can be reorganized to cleanly support different reporting targets, but I hadn't thought this through. |
Hello, Please find my comments:
I see that I have some inconsistent arguments for domoticz mode. I added to domoticz mode arguments called "-m {oneshot,monitor}" to be able to have oneshot or monitor mode when reporting to domoticz. Honestly I would see the arguments as follows when in domoticz mode: While we have now: |
GPIO object does not have pin attribute anymore. Use line instead
Hello I forked your PMS5003 library and added support for sending datat to domoticz. You may want to add my changes to your code.
Regards,
Marcin
PS: My fork can be found at: https://github.com/mstojek/pms5003-logger