Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump serverless k8s dependency to a common version #563

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Bump serverless k8s dependency to a common version #563

merged 3 commits into from
Jan 10, 2024

Conversation

halamix2
Copy link
Member

@halamix2 halamix2 commented Jan 10, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Bump serverleass k8s dependency to a common version to simplify go.mod merge afterwards
  • fix failing test (failing after sigs.k8s.io/controller-runtime bump)

Related issue(s)

/retest

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 10, 2024
@halamix2
Copy link
Member Author

/retest

@halamix2 halamix2 changed the title Bump serverleass k8s dependency to a common version Bump serverless k8s dependency to a common version Jan 10, 2024
@halamix2 halamix2 marked this pull request as ready for review January 10, 2024 12:15
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2024
@Cortey Cortey self-assigned this Jan 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2024
@kyma-bot kyma-bot merged commit fca310d into kyma-project:main Jan 10, 2024
19 checks passed
@halamix2 halamix2 deleted the bump-serverless-to-common-api branch January 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cortey Cortey Cortey approved these changes

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@dbadura dbadura Awaiting requested review from dbadura

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@Cortey Cortey

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @kyma-bot @Cortey