Implement proper port for prometheus #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbadura
requested review from
pPrecel,
kwiatekus,
Cortey,
anoipm and
MichalKalke
as code owners
kyma-bot
added
cla: yes
|
/retest |
dbadura
added
do-not-merge/hold
anoipm
reviewed
Jan 10, 2024
| @@ -186,22 +186,48 @@ func mapsEqual(existing, expected map[string]string) bool { | |||
| return true | |||
| } | |||
|
|
|||
| func mapsContains(existing, contains map[string]string) bool { | |||
There was a problem hiding this comment.
I have problem with understanding which value is which - existing and contains say me nothing.
anoipm
approved these changes
Jan 10, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#496