Skip to content

Commit

Permalink
Make loki and jaeger datasource configurable for grafana (#9283)
Browse files Browse the repository at this point in the history
* Make loki and jaeger datasource configurable

 - We should keep additional datasource in for grafana and loki configurable.
   So that we can control them via overrides if on of the component is not present

* fixes

* Remove unused key
  • Loading branch information
rakesh-garimella authored and dariadomagala-sap committed Aug 24, 2020
1 parent 7ce2eca commit 6114605
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ data:
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.grafana.dataSources.loki.enabled }}
{{ toYaml .Values.grafana.dataSources.loki.config | indent 4}}
{{- end }}
{{- if .Values.grafana.dataSources.jaeger.enabled }}
{{ toYaml .Values.grafana.dataSources.jaeger.config | indent 4}}
{{- end }}
{{- if .Values.grafana.additionalDataSources }}
{{ toYaml .Values.grafana.additionalDataSources | indent 4}}
{{- end }}
Expand Down
34 changes: 22 additions & 12 deletions resources/monitoring/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -515,19 +515,29 @@ grafana:

## Configure additional grafana datasources
## ref: https://grafana.com/docs/grafana/latest/features/datasources/


dataSources:
loki:
enabled: true
config:
- name: Loki
type: loki
access: proxy
url: http://logging-loki.kyma-system:3100
editable: true
jsonData:
maxLines: 1000
jaeger:
enabled: true
config:
- name: Jaeger
type: jaeger
access: proxy
url: http://tracing-jaeger-query.kyma-system:16686
editable: true

additionalDataSources:
- name: Loki
type: loki
access: proxy
url: http://logging-loki.kyma-system:3100
editable: true
jsonData:
maxLines: 1000
- name: Jaeger
type: jaeger
access: proxy
url: http://tracing-jaeger-query.kyma-system:16686
editable: true
# - name: prometheus-sample
# access: proxy
# basicAuth: true
Expand Down

0 comments on commit 6114605

Please sign in to comment.