Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start options to support debugpy #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

friedrichwilken
Copy link
Collaborator

Description

Changes proposed in this pull request:

  • add start options in main.py to allow debugg via debugpy, the DAP implementation for Python that is supportet by NVim, as mentioned in the official docs of FastAPI

Related issue(s)

@friedrichwilken friedrichwilken requested a review from a team as a code owner February 5, 2025 15:21
Copy link

github-actions bot commented Feb 5, 2025

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

src/main.py Outdated
Comment on lines 28 to 31


if __name__ == "__main__":
uvicorn.run(app, host="localhost", port=8000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this to run the app with python src/main.py?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, if I want to debug it, I do need this, as the referenced docs of FastAPI shows.

Copy link
Collaborator

@muralov muralov Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow fastapi cli is the recommended way in the docs https://fastapi.tiangolo.com/#standard-dependencies.
Can you share the doc that you read? I really used uvicorn in the main and there were some issue for me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyma-bot kyma-bot added the size/S label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants