Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user, password and database-number as configurables to build redis URL #341

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

friedrichwilken
Copy link
Collaborator

…s URL

Description

Changes proposed in this pull request:

  • add user, password and database-number as configurables to build redis URL

Related issue(s)

Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

@friedrichwilken friedrichwilken changed the title feature: add user, password and database-number as configurables to build redis URL feat: add user, password and database-number as configurables to build redis URL Jan 16, 2025
@mfaizanse mfaizanse added evaluation requested A PR with this label will trigger the validation workflow. and removed cla: yes labels Jan 16, 2025
@kyma-bot kyma-bot added the lgtm label Jan 16, 2025
@kyma-bot kyma-bot merged commit 4223e3a into main Jan 16, 2025
20 of 22 checks passed
@friedrichwilken friedrichwilken deleted the add-pw-user-number-to-redis-url branch January 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes evaluation requested A PR with this label will trigger the validation workflow. lgtm run-integration-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants