Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added langfuse secrets #336

Closed
wants to merge 2 commits into from
Closed

chore: added langfuse secrets #336

wants to merge 2 commits into from

Conversation

tanweersalah
Copy link
Contributor

@tanweersalah tanweersalah commented Jan 14, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Added langfuse secrets

Related issue(s)

#337

@tanweersalah tanweersalah requested a review from a team as a code owner January 14, 2025 14:56
@github-actions GitHub Actions
Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

@tanweersalah tanweersalah requested review from muralov and removed request for marcobebway January 14, 2025 14:56
@tanweersalah tanweersalah changed the title GitHub actions chore: added langfuse secrets Jan 14, 2025
@tanweersalah tanweersalah linked an issue Jan 14, 2025 that may be closed by this pull request
add langfuse secrets in github actions #337
Closed
muralov
muralov reviewed Jan 14, 2025
View reviewed changes
.github/workflows/pull-integration-test.yaml
# Langfuse configuration
LANGFUSE_HOST: ${{ steps.int-tests-configs.outputs.LANGFUSE_HOST }}
LANGFUSE_PUBLIC_KEY: ${{ steps.int-tests-configs.outputs.LANGFUSE_PUBLIC_KEY }}
LANGFUSE_SECRET_KEY: ${{ steps.int-tests-configs.outputs.LANGFUSE_SECRET_KEY }}
run: |
echo "${{ secrets.MODELS_JSON }}" | base64 --decode | jq > $GITHUB_WORKSPACE/config/config.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it later that we can add the Langfuse config in MODELS_JSON config. Let me add inside the it and then we don't need any change.

@tanweersalah tanweersalah deleted the github-actions branch January 14, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muralov muralov muralov left review comments

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add langfuse secrets in github actions
3 participants
@tanweersalah @muralov @kyma-bot