chore: improve the Indexer #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note(s) for PR Auther:
Note(s) for PR Reviewer(s):
|
* Index with batches to prevent rate limiting * Clean-up table after test run * Add more logs
muralov
force-pushed
the
improve-doc-indexer
branch
from
4986911 to
6408e80
Compare
mfaizanse
reviewed
Oct 30, 2024
doc_indexer/src/utils/settings.py
Outdated
| @@ -5,6 +5,8 @@ | |||
| from decouple import Config, RepositoryEnv, config | |||
| from dotenv import find_dotenv, load_dotenv | |||
|
|
|||
| # TODO: re-use the settings parent project | |||
There was a problem hiding this comment.
Is it todo suppose to be completed as part of this PR?
There was a problem hiding this comment.
it should be part of this issue. Do you want me to add the issue link to the comment too?
There was a problem hiding this comment.
I've added the issue link too.
There was a problem hiding this comment.
Please remove the todo comment from the code then. Having it in the issue is enough.
doc_indexer/src/utils/settings.py
Outdated
| DOCS_PATH = config("DOCS_PATH", default=None) | ||
| DOCS_PATH = config("DOCS_PATH", default="data/output") | ||
| DOCS_TABLE_NAME = config("DOCS_TABLE_NAME", default="kyma_docs") | ||
| CHUNKS_BATCH_SIZE = config("CHUNKS_BATCH_SIZE", cast=int, default=100) |
There was a problem hiding this comment.
Is 100 the best possible chunk size?
There was a problem hiding this comment.
number of chunks is 474, that means there will 5 batches. I tested with 200 batch size. It was successful multiple times and increased it to 200. We can configure it later if we want to increase more.
muralov
force-pushed
the
improve-doc-indexer
branch
from
9ae17e9 to
263a387
Compare
muralov
force-pushed
the
improve-doc-indexer
branch
from
263a387 to
956a493
Compare
mfaizanse
approved these changes
Oct 30, 2024
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#199