fix: Revert enabling prometheusMerge feature #1184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The enablement of the prometheusMerge feature was tested thoroughly with the Kyma telemetry feature and decided that on the current landscapes will not introduce a breaking change. Unfortunately, the analysis missed the fact that users can run a prometheus with a sidecar which is having a scrape loop for pod-based prometheus annotations, which scrapes istiofied workload using https, see https://github.com/kyma-project/examples/tree/main/prometheus for an example. Indeed, this scenario is a breaking change as after enabling the feature, the prometheus will call the new istio endpoint still with https, but the endpoint does not support TLS anymore.
This PR is reverting the change, and the feature will get introduced properly by having a configuration option which is disabled by default in ticket #1185.
Changes proposed in this pull request:
Pre-Merge Checklist
Related issues
#1114
kyma-project/telemetry-manager#1468
#1185