Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert enabling prometheusMerge feature #1184

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

a-thaler
Copy link
Contributor

@a-thaler a-thaler commented Dec 11, 2024

Description

The enablement of the prometheusMerge feature was tested thoroughly with the Kyma telemetry feature and decided that on the current landscapes will not introduce a breaking change. Unfortunately, the analysis missed the fact that users can run a prometheus with a sidecar which is having a scrape loop for pod-based prometheus annotations, which scrapes istiofied workload using https, see https://github.com/kyma-project/examples/tree/main/prometheus for an example. Indeed, this scenario is a breaking change as after enabling the feature, the prometheus will call the new istio endpoint still with https, but the endpoint does not support TLS anymore.

This PR is reverting the change, and the feature will get introduced properly by having a configuration option which is disabled by default in ticket #1185.

Changes proposed in this pull request:

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

#1114
kyma-project/telemetry-manager#1468
#1185

@a-thaler a-thaler requested a review from a team as a code owner December 11, 2024 12:45
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@strekm strekm added this to the 1.11.1 milestone Dec 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2024
@barchw barchw mentioned this pull request Dec 11, 2024
1 task
@barchw barchw merged commit 8fdb95a into kyma-project:main Dec 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants