Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup restore 4 #592

Merged
merged 11 commits into from
Jan 10, 2025
Merged

Backup restore 4 #592

merged 11 commits into from
Jan 10, 2025

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Jan 7, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Labeling crbs moved to the backup tool
  • Backup tool switches runtime to be controlled by KIM once the backup was successfully created
  • Adjustments to the migrator:
    • Some irrelevant fields not set on Runtime CR (e.g. generateName)
    • Both backup and migrator take into account worker fields that are directly set by KEB, and skip others
    • Annotation fields are no longer set on Runtime CR

Related issue(s)
#557

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 7, 2025
@akgalwas akgalwas mentioned this pull request Jan 7, 2025
Open
5 tasks
@akgalwas akgalwas marked this pull request as ready for review January 9, 2025 10:56
@akgalwas akgalwas requested a review from a team as a code owner January 9, 2025 10:56
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 9, 2025
m00g3n
m00g3n previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 10, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2025
@kyma-bot kyma-bot merged commit f7af399 into kyma-project:main Jan 10, 2025
9 checks passed
@akgalwas akgalwas deleted the backup-restore-4 branch January 10, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disper Disper Disper approved these changes

@m00g3n m00g3n m00g3n left review comments

Assignees

@Disper Disper

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akgalwas @Disper @m00g3n @kyma-bot