Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced kyma/epp package with local EPP package and fixed lint issues #15

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Replaced kyma/epp package with local EPP package and fixed lint issues #15

merged 3 commits into from
Dec 13, 2023

Conversation

mfaizanse
Copy link
Member

@mfaizanse mfaizanse commented Dec 13, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Replaced kyma/epp package with local EPP package.
  • Fixed lint issues.

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
@mfaizanse mfaizanse changed the title Replaced kyma/epp package with local EPP package Replaced kyma/epp package with local EPP package and fixed lint issues Dec 13, 2023
@mfaizanse mfaizanse marked this pull request as ready for review December 13, 2023 14:01
@mfaizanse mfaizanse requested a review from a team as a code owner December 13, 2023 14:01
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2023
friedrichwilken
friedrichwilken reviewed Dec 13, 2023
View reviewed changes
pkg/cloudevents/eventtype/eventtypetest/eventtypetest.go
@@ -15,7 +15,3 @@ func (c CleanerStub) Clean(_ string) (string, error) {
func (cf CleanerFunc) Clean(eventType string) (string, error) {
return cf(eventType)
}

var DefaultCleaner = func(eventType string) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was not used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it was not used.

pkg/nats/connect.go Show resolved Hide resolved
pkg/oauth/client.go Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2023
@kyma-bot kyma-bot merged commit 70cd4c8 into kyma-project:main Dec 13, 2023
1 check passed
@mfaizanse mfaizanse deleted the pkg_update branch December 13, 2023 14:43
@mfaizanse mfaizanse linked an issue Dec 13, 2023 that may be closed by this pull request
move EPP out of kyma into the eventing-manager and setup pipelines / cleanup old pipelines kyma-project/kyma#18439
Closed
7 tasks
mfaizanse added a commit that referenced this pull request Dec 14, 2023
@mfaizanse
Replaced kyma/epp package with local EPP package and fixed lint issues (
8b51ff4 
#15)

* Replaced kyma/epp pkg with local pkgs

* fixed lint issues
@grischperl grischperl added this to the 1.0.0 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

Assignees

@friedrichwilken friedrichwilken

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

move EPP out of kyma into the eventing-manager and setup pipelines / cleanup old pipelines
4 participants
@mfaizanse @friedrichwilken @kyma-bot @grischperl