feat: Add ability to expand manually added module to kyma #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbadura
requested review from
akucharska,
mrCherry97,
chriskari and
OliwiaGowor
as code owners
kyma-bot
added
cla: yes
dbadura
changed the title
akucharska
reviewed
Feb 11, 2025
| @@ -382,6 +391,7 @@ export default function KymaModulesList({ | |||
| }; | |||
|
|
|||
| const getAssociatedResources = () => { | |||
| // TODO: tutaj leci undefined dla 1 i 3 argumentu | |||
There was a problem hiding this comment.
Nice TODO. How about fixing it?
There was a problem hiding this comment.
It should be fixed now.
| const isExtension = !!findExtension(resource?.resource?.kind); | ||
| const moduleStatus = findStatus(kymaResource, resourceName); | ||
| const moduleStatus = resource; |
There was a problem hiding this comment.
If it's no longer assigned to findStatus maybe it will be better to remove this variable and use resource directly
kyma-bot
added
size/L
akucharska
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3624
Definition of done
backlog#4567