Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Additional tab stop after SideNav with screen reader #3655

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: Additional tab stop after SideNav with screen reader #3655

merged 1 commit into from
Feb 4, 2025

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Feb 3, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • removed YamlEditorContext.js file
  • removed unused imports

Related issue(s)
Closes #3151

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Feb 3, 2025
@OliwiaGowor OliwiaGowor marked this pull request as ready for review February 3, 2025 14:42
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 3, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 4, 2025
@mrCherry97 mrCherry97 merged commit e18e0d6 into kyma-project:main Feb 4, 2025
83 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACC-264.1, ACC-271.1 (Level A) _ Modify Modules _ Navigation menu _ Additional tab stop with speech output
3 participants
@OliwiaGowor @mrCherry97 @kyma-bot