fix: add modules shouldn't reset after some time #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
dbadura
changed the title
dbadura
requested review from
akucharska,
mrCherry97,
chriskari and
OliwiaGowor
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
mrCherry97
requested changes
Jan 21, 2025
There was a problem hiding this comment.
View is not jumping, and also delete modal is not jumping, so looks good, but selectedModules or newModules state is not working correctly, when I select some of the modules, click Cancel -> Discard and open Add Modules one more time, then Modules are still selected (no of the module should be selected on first open of the Add)
Screen.Recording.2025-01-21.at.13.45.48.mov
4 tasks
mrCherry97
previously requested changes
Jan 24, 2025
| if (selectedModules && kymaResource) { | ||
| const mergedModules = activeKymaModules.concat( | ||
| selectedModules.filter( | ||
| i => !activeKymaModules.find(j => j.name === i.name), |
There was a problem hiding this comment.
rename this i and j to something more readable
mrCherry97
dismissed
their stale review
Looks that it's working in the Add Modules view, delete is still jumping, but we will revisit that after refactor.
akucharska
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
selectedModulesstate correctlyRelated issue(s)
#3591
Definition of done
backlog#4567