Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: header actions in namespace overview are truncated after relaoding the page #3561

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix: header actions in namespace overview are truncated after relaoding the page #3561

wants to merge 13 commits into from

Conversation

KonradPietocha
Copy link
Contributor

@KonradPietocha KonradPietocha commented Dec 27, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fixes header action clipping,
  • Changing some js files to tsx,
  • Limiting the number of iterations by using conditions in a single filter

Related issue(s)
Closes #3505

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 27, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 27, 2024
@dbadura dbadura self-assigned this Dec 30, 2024
dbadura
dbadura reviewed Dec 30, 2024
View reviewed changes
src/shared/components/ResourceDetails/ResourceDetails.js Outdated
?.filter(col => col?.fullWidth && col?.fullWidth === true)
?.filter(
col =>
filterColumns(col) &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider to rename this filter fn to mean something more

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbadura dbadura dbadura left review comments

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dbadura dbadura

Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header actions in namespace overview are truncated after relaoding the page
3 participants
@KonradPietocha @dbadura @kyma-bot