Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable internal traffic for workloads exposed by v2alpha1 APIRule #1666

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Feb 4, 2025

Description

Changes proposed in this pull request:

  • Enable internal traffic for workloads exposed by v2alpha1 APIRule

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@barchw barchw marked this pull request as ready for review February 4, 2025 09:38
@barchw barchw requested a review from a team as a code owner February 4, 2025 09:38
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Feb 4, 2025
@kubicar kubicar self-requested a review February 4, 2025 14:39
kubicar
kubicar previously approved these changes Feb 4, 2025
Copy link
Contributor

@kubicar kubicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it's work, to code one comment left

internal/builders/istio.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 4, 2025
@kubicar kubicar requested a review from a team February 4, 2025 14:40
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 4, 2025
@barchw barchw requested a review from a team as a code owner February 4, 2025 15:52
kubicar
kubicar previously approved these changes Feb 5, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 5, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 6, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 7, 2025
@barchw barchw merged commit a97fae9 into kyma-project:main Feb 7, 2025
16 checks passed
@barchw barchw deleted the internal-traffic branch February 7, 2025 13:32
barchw added a commit to barchw/api-gateway-1 that referenced this pull request Feb 7, 2025
…ma-project#1666)

* Enable internal traffic for workloads exposed by v2alpha1 APIRule

* Remove with labels

* Add RN

* Update desired_test.go

* Revert changes of get service selector

* Switch logic to allow instead of disallow

* Update docs/release-notes/2.12.0.md

Co-authored-by: Natalia Sitko <[email protected]>

* Pass down podSelector from top to bottom

---------

Co-authored-by: Natalia Sitko <[email protected]>
barchw added a commit to barchw/api-gateway-1 that referenced this pull request Feb 7, 2025
…ma-project#1666)

* Enable internal traffic for workloads exposed by v2alpha1 APIRule

* Remove with labels

* Add RN

* Update desired_test.go

* Revert changes of get service selector

* Switch logic to allow instead of disallow

* Update docs/release-notes/2.12.0.md

Co-authored-by: Natalia Sitko <[email protected]>

* Pass down podSelector from top to bottom

---------

Co-authored-by: Natalia Sitko <[email protected]>
barchw added a commit that referenced this pull request Feb 7, 2025
…pha1 APIRule (#1686)

* Enable internal traffic for workloads exposed by v2alpha1 APIRule (#1666)

* Enable internal traffic for workloads exposed by v2alpha1 APIRule

* Remove with labels

* Add RN

* Update desired_test.go

* Revert changes of get service selector

* Switch logic to allow instead of disallow

* Update docs/release-notes/2.12.0.md

Co-authored-by: Natalia Sitko <[email protected]>

* Pass down podSelector from top to bottom

---------

Co-authored-by: Natalia Sitko <[email protected]>

* Add RN for 2.10.4

---------

Co-authored-by: Natalia Sitko <[email protected]>
barchw added a commit that referenced this pull request Feb 7, 2025
…pha1 APIRule (#1687)

* Enable internal traffic for workloads exposed by v2alpha1 APIRule (#1666)

* Enable internal traffic for workloads exposed by v2alpha1 APIRule

* Remove with labels

* Add RN

* Update desired_test.go

* Revert changes of get service selector

* Switch logic to allow instead of disallow

* Update docs/release-notes/2.12.0.md

Co-authored-by: Natalia Sitko <[email protected]>

* Pass down podSelector from top to bottom

---------

Co-authored-by: Natalia Sitko <[email protected]>

* Add RN for 2.11.1

---------

Co-authored-by: Natalia Sitko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants