Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix bucket validation in ratelimit_types.go #1633

Merged
merged 1 commit into from
Jan 22, 2025
Merged

bug: fix bucket validation in ratelimit_types.go #1633

merged 1 commit into from
Jan 22, 2025

Conversation

Ressetkk
Copy link
Contributor

@Ressetkk Ressetkk commented Jan 22, 2025 •
edited
Loading

As defined in ADR, allow scenario where both path and headers can be defined for single token bucket.
Cover with controller integration tests.

It is also possible to combine request descriptors, for example rate limit on path and headers, in the same rate limit configuration. In this case the rate limit is applied only if all specified descriptors are present in the request.

/kind bug
/area api-gateway

#1629

@Ressetkk
bug: fix bucket validation in ratelimit_types.go
209b606 
As defined in ADR, allow scenario where both `path` and `headers` can be defined for single token bucket
@Ressetkk Ressetkk requested a review from a team as a code owner January 22, 2025 11:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
kubicar
kubicar approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@kubicar kubicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 22, 2025
@kubicar kubicar assigned Ressetkk and unassigned kubicar Jan 22, 2025
@Ressetkk Ressetkk merged commit d557378 into kyma-project:main Jan 22, 2025
14 of 15 checks passed
@mluk-sap mluk-sap mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubicar kubicar kubicar approved these changes

Assignees

@Ressetkk Ressetkk

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ressetkk @kubicar @kyma-bot