Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix using datetime.now().strftime() to format the time on spreadsh… #710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hotfix using datetime.now().strftime() to format the time on spreadsh… #710

wants to merge 1 commit into from
+758 −109

Conversation

jmikedupont2
Copy link

@jmikedupont2 jmikedupont2 commented Dec 31, 2024 •
edited by github-actions bot
Loading

steps

git remote add name url
git fetch --all

git checkout -b patrickbdevaney_master patrickbdevaney/master
git rebase upstream/master
squashed all commits

…eet_swarm.py

adding unit test for spreadsheet_swarm

fixing issues with linting tests ruff

more linting tests

linting fixes and QA on spreadsheet_swarm.py

spreadsheet_swarm.py confirmed working on windows in tests with Harshal

multi platform spreadsheet_swarm, deps build clusterops from github source

spreadsheet and syntax fix to auto_test_eval.py

spreadsheet and finance tests confirmed to work

align repo with upstream

Thank you for contributing to Swarms!

Replace this comment with:

  • Description: a description of the change,
  • Issue: the issue # it fixes (if applicable),
  • Dependencies: any dependencies required for this change,
  • Tag maintainer: for a quicker response, tag the relevant maintainer (see below),
  • Twitter handle: we announce bigger features on Twitter. If your PR gets announced and you'd like a mention, we'll gladly shout you out!

Please make sure your PR is passing linting and testing before submitting. Run make format, make lint and make test to check this locally.

See contribution guidelines for more information on how to write/run tests, lint, etc:
https://github.com/kyegomez/swarms/blob/master/CONTRIBUTING.md

If you're adding a new integration, please include:

  1. a test for the integration, preferably unit tests that do not rely on network access,
  2. an example notebook showing its use.

Maintainer responsibilities:

If no one reviews your PR within a few days, feel free to email Kye at [email protected]

See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/kyegomez/swarms

📚 Documentation preview 📚: https://swarms--710.org.readthedocs.build/en/710/

@patrickbdevaney
hotfix using datetime.now().strftime() to format the time on spreadsh…
8258483 
…eet_swarm.py

adding unit test for spreadsheet_swarm

fixing issues with linting tests ruff

more linting tests

linting fixes and QA on spreadsheet_swarm.py

spreadsheet_swarm.py confirmed working on windows in tests with Harshal

multi platform spreadsheet_swarm, deps build clusterops from github source

spreadsheet and syntax fix to auto_test_eval.py

spreadsheet and finance tests confirmed to work

align repo with upstream
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 31, 2024
View reviewed changes
tests/agent_evals/auto_test_eval.py
github_token=os.getenv("GITHUB_API_KEY")
)

reporter = SwarmsIssueReporter(github_token=os.getenv("GITHUB_API_KEY"))

Check failure

Code scanning / Pyre

Incompatible parameter type Error test

Incompatible parameter type [6]: In call SwarmsIssueReporter.\_\_init\_\_, for argument github\_token, expected str but got Optional[str].
tests/structs/test_financial_agent.py
import asyncio
from typing import Optional, Dict, Any, List, Tuple
from datetime import datetime
from loguru import logger

Check failure

Code scanning / Pyre

Undefined import Error test

Undefined import [21]: Could not find a module corresponding to import loguru.
tests/structs/test_spreadsheet_swarm_v2.py
import asyncio
from typing import List, Dict, Any, Optional, Tuple
from datetime import datetime
from loguru import logger

Check failure

Code scanning / Pyre

Undefined import Error test

Undefined import [21]: Could not find a module corresponding to import loguru.
tests/structs/test_spreadsheet_swarm_v2.py
# Verify configuration
assert swarm.name == "Test Swarm"
assert swarm.description == "Test Description"
assert len(swarm.agents) == 2

Check failure

Code scanning / Pyre

Incompatible parameter type Error test

Incompatible parameter type [6]: In call len, for 1st positional argument, expected pyre\_extensions.PyreReadOnly[Sized] but got Optional[List[Agent]].
tests/structs/test_spreadsheet_swarm_v2.py

# Test empty initialization
empty_swarm = SpreadSheetSwarm()
assert len(empty_swarm.agents) == 0

Check failure

Code scanning / Pyre

Incompatible parameter type Error test

Incompatible parameter type [6]: In call len, for 1st positional argument, expected pyre\_extensions.PyreReadOnly[Sized] but got Optional[List[Agent]].
tests/structs/test_spreadsheet_swarm_v2.py
swarm = SpreadSheetSwarm(load_path=csv_path)
await swarm._load_from_csv()

assert len(swarm.agents) == 3

Check failure

Code scanning / Pyre

Incompatible parameter type Error test

Incompatible parameter type [6]: In call len, for 1st positional argument, expected pyre\_extensions.PyreReadOnly[Sized] but got Optional[List[Agent]].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandra-Amina-Boss Sandra-Amina-Boss Sandra-Amina-Boss approved these changes

Assignees
No one assigned
Labels
structs tests tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikedupont2 @Sandra-Amina-Boss @patrickbdevaney