Expose showFullScreen and showNormal methods of QMainWindow #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katafrakt
force-pushed
the
fullscreen
branch
2 times, most recently
from
0817741 to
7a0d1eb
Compare
|
Okay, I figured it's better not to touch |
|
@kusti8 any thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to see fullscreen windows in proton-native. I've manage to get it run locally, but first exposing methods here seems to be required.
I only added support for
showFullScreenandshowNormal, without maximized and minimized (I think I have never seen an app using them), but those too can be added too. Or maybe you think it would be better to control it viasetWindowStates(Qt::WindowFullScreen)?As there's no readme, I don't know if I should commit
.mocfiles. Also version was automatically bumped up and I commited that too.Let me know what you think.