Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GatewayAPI): use MeshHTTPRoutes instead of MeshGatewayRoutes internally #9732

Merged
merged 11 commits into from
Apr 3, 2024
Merged

feat(GatewayAPI): use MeshHTTPRoutes instead of MeshGatewayRoutes internally #9732

merged 11 commits into from
Apr 3, 2024

Conversation

bartsmykla
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Unit tests updated
    • Existing e2e (including GatewayAPI conformance) tests passes
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • There is no need

@bartsmykla bartsmykla added the area/gateway Built-in Kuma gateway support label Mar 27, 2024
@bartsmykla bartsmykla requested a review from a team as a code owner March 27, 2024 09:04
@bartsmykla bartsmykla requested review from slonka and lobkovilya and removed request for a team March 27, 2024 09:04
@bartsmykla bartsmykla force-pushed the feat/gapi-use-meshhttproutes-instead-of-meshgatewayroutes-internally branch from 59b6e52 to 1e6c13f Compare March 27, 2024 09:07
@bartsmykla bartsmykla force-pushed the feat/gapi-use-meshhttproutes-instead-of-meshgatewayroutes-internally branch from 1e6c13f to d0b0e05 Compare March 27, 2024 09:08
@bartsmykla bartsmykla added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Apr 3, 2024
@michaelbeaumont michaelbeaumont changed the title feat(GAPI): use MesHTTPRoutes instead of MeshGatewayRoutes internally feat(GAPI): use MeshHTTPRoutes instead of MeshGatewayRoutes internally Apr 3, 2024
@michaelbeaumont michaelbeaumont changed the title feat(GAPI): use MeshHTTPRoutes instead of MeshGatewayRoutes internally feat(gatewayapi): use MeshHTTPRoutes instead of MeshGatewayRoutes internally Apr 3, 2024
@bartsmykla
Merge remote-tracking branch 'upstream/master' into feat/gapi-use-mes…
5892f7e 
…hhttproutes-instead-of-meshgatewayroutes-internally
@bartsmykla
chore: address review remarks
c977e5d 
Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla enabled auto-merge (squash) April 3, 2024 11:33
@bartsmykla bartsmykla merged commit 5310732 into kumahq:master Apr 3, 2024
35 checks passed
@bartsmykla bartsmykla deleted the feat/gapi-use-meshhttproutes-instead-of-meshgatewayroutes-internally branch April 3, 2024 11:34
@bartsmykla bartsmykla mentioned this pull request Apr 9, 2024
Closed
@lahabana lahabana changed the title feat(gatewayapi): use MeshHTTPRoutes instead of MeshGatewayRoutes internally feat(GatewayApi): use MeshHTTPRoutes instead of MeshGatewayRoutes internally Apr 11, 2024
@lahabana lahabana changed the title feat(GatewayApi): use MeshHTTPRoutes instead of MeshGatewayRoutes internally feat(GatewayAPI): use MeshHTTPRoutes instead of MeshGatewayRoutes internally Apr 15, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
area/gateway Built-in Kuma gateway support ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MeshHTTPRoute everywhere for Gateway API
2 participants
@bartsmykla @michaelbeaumont