Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MADR): add Kubernetes UX for MeshService #9722

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- MADR for Kubernetes UX of MeshService  #9704
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont force-pushed the docs/kubernetes-ux-meshservice branch from 202867e to 2885b60 Compare March 26, 2024 13:48
@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Mar 26, 2024
@michaelbeaumont michaelbeaumont marked this pull request as ready for review April 2, 2024 11:02
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner April 2, 2024 11:02
@michaelbeaumont michaelbeaumont requested review from slonka, jakubdyszkiewicz and Automaat and removed request for a team April 2, 2024 11:02
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really too much to add, would be good to see an example as mentioned by Marcin.

@michaelbeaumont michaelbeaumont force-pushed the docs/kubernetes-ux-meshservice branch from 8cc0eaf to 0e15744 Compare April 8, 2024 14:37
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really hard to do another review when it's force pushed. I see you added the example (the thing that I mentioned in the previous review).

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not very convinced by the headless service implem...

The rest looks great though!

@michaelbeaumont michaelbeaumont linked an issue Apr 24, 2024 that may be closed by this pull request
@michaelbeaumont michaelbeaumont merged commit fe1f4fa into kumahq:master Apr 24, 2024
11 checks passed
@michaelbeaumont michaelbeaumont deleted the docs/kubernetes-ux-meshservice branch April 24, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MADR for Kubernetes UX of MeshService
6 participants