Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(.github): migrate to github action instead of circleCI #8593

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

lahabana
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana requested a review from a team as a code owner December 12, 2023 08:53
@lahabana lahabana requested review from michaelbeaumont, jakubdyszkiewicz and jijiechen and removed request for a team December 12, 2023 08:53
On setup connections were left open sometimes

Signed-off-by: Charly Molter <[email protected]>
@jijiechen
Copy link
Member

LGTM.

Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana merged commit daea20a into kumahq:master Dec 12, 2023
22 checks passed
@lahabana lahabana deleted the cutoffToGithub branch March 29, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants