Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): explain use of WithSkipDefaultMesh better #8499

Merged
merged 1 commit into from
Nov 30, 2023
Merged

test(e2e): explain use of WithSkipDefaultMesh better #8499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/e2e/helm/kuma_helm_deploy_global_and_zone_universal_mode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ stringData:

err = NewClusterSetup().
Install(Kuma(core.Zone,
// it's required because we check if Kuma is ready,
// and we use "kubectl get mesh" which is not available in universal mode
// WithSkipDefaultMesh is required because we check if Kuma is ready by using "kubectl get mesh"
// here in the framework https://github.com/kumahq/kuma/blob/1633d34ad116dd1e618f4a27dd1526f5ff7d8bde/test/framework/k8s_cluster.go#L564
// but on universal mode we use postgres to manage resources so without this it will fail making the test suite fail
WithSkipDefaultMesh(true),
WithInstallationMode(HelmInstallationMode),
WithHelmReleaseName(releaseName),
Expand Down
5 changes: 3 additions & 2 deletions test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ stringData:

err = NewClusterSetup().
Install(Kuma(core.Global,
// it's required because we check if Kuma is ready,
// and we use "kubectl get mesh" which is not available in universal mode
// WithSkipDefaultMesh is required because we check if Kuma is ready by using "kubectl get mesh"
// here in the framework https://github.com/kumahq/kuma/blob/1633d34ad116dd1e618f4a27dd1526f5ff7d8bde/test/framework/k8s_cluster.go#L564
// but on universal mode we use postgres to manage resources so without this it will fail making the test suite fail
WithSkipDefaultMesh(true),
WithInstallationMode(HelmInstallationMode),
WithHelmReleaseName(releaseName),
Expand Down
Loading