-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(policy): add extra testing of the matching algorithm #8487
Conversation
Add some tests including one as pending which is the repro Fix kumahq#8484 Signed-off-by: Charly Molter <[email protected]>
Tests in this PR are not expected to pass, because sorting normally is happening here kuma/pkg/plugins/policies/core/matchers/dataplane.go Lines 63 to 67 in b249dab
But the test calls |
If you place the same test here |
Yeah that's what I've noticed later |
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Yeah I noticed that after so I added tests there as well and it seems to be working correctly. |
test.EntriesForFolder
Ref #8484
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --