feat(kuma-cp): hash-suffix remove feature flag

docs/generated/kuma-cp.md

@@ -748,11 +748,6 @@ experimental:
   # If true then control plane computes reachable services automatically based on MeshTrafficPermission.
   # Lack of MeshTrafficPermission is treated as Deny the traffic.
   autoReachableServices: false # ENV: KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES
-  # KDSSyncNameWithHashSuffix if true then during KDS sync resource name is going to be suffixed with hash.
-  # The hash is computed based on various resource characteristics like mesh, namespace, etc. The feature prevents name
-  # collisions when syncing policies with the same names but different meshes from Global(Universal) to Zone(Kubernetes).
-  # More extensive explanation of the problem and solution can be found in the MADR https://github.com/kumahq/kuma/blob/master/docs/madr/decisions/029-kds-sync-hash-suffix.md
-  KDSSyncNameWithHashSuffix: false # ENV: KUMA_EXPERIMENTAL_KDS_SYNC_NAME_WITH_HASH_SUFFIX
 
 proxy:
   gateway:

docs/generated/raw/kuma-cp.yaml

@@ -745,11 +745,6 @@ experimental:
   # If true then control plane computes reachable services automatically based on MeshTrafficPermission.
   # Lack of MeshTrafficPermission is treated as Deny the traffic.
   autoReachableServices: false # ENV: KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES
-  # KDSSyncNameWithHashSuffix if true then during KDS sync resource name is going to be suffixed with hash.
-  # The hash is computed based on various resource characteristics like mesh, namespace, etc. The feature prevents name
-  # collisions when syncing policies with the same names but different meshes from Global(Universal) to Zone(Kubernetes).
-  # More extensive explanation of the problem and solution can be found in the MADR https://github.com/kumahq/kuma/blob/master/docs/madr/decisions/029-kds-sync-hash-suffix.md
-  KDSSyncNameWithHashSuffix: false # ENV: KUMA_EXPERIMENTAL_KDS_SYNC_NAME_WITH_HASH_SUFFIX
 
 proxy:
   gateway:

pkg/config/app/kuma-cp/config.go

@@ -262,7 +262,6 @@ var DefaultConfig = func() Config {
 				FullResyncInterval: config_types.Duration{Duration: 1 * time.Minute},
 				DelayFullResync:    false,
 			},
-			KDSSyncNameWithHashSuffix: false,
 		},
 		Proxy:    xds.DefaultProxyConfig(),
 		InterCp:  intercp.DefaultInterCpConfig(),
@@ -407,9 +406,6 @@ type ExperimentalConfig struct {
 	// If true then control plane computes reachable services automatically based on MeshTrafficPermission.
 	// Lack of MeshTrafficPermission is treated as Deny the traffic.
 	AutoReachableServices bool `json:"autoReachableServices" envconfig:"KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES"`
-	// KDSSyncNameWithHashSuffix if true then during KDS sync resource name is going to be suffixed with hash.
-	// The hash is computed based on various resource characteristics like mesh, namespace, etc.
-	KDSSyncNameWithHashSuffix bool `json:"kdsSyncNameWithHashSuffix" envconfig:"KUMA_EXPERIMENTAL_KDS_SYNC_NAME_WITH_HASH_SUFFIX"`
 }
 
 type ExperimentalKDSEventBasedWatchdog struct {

pkg/config/app/kuma-cp/kuma-cp.defaults.yaml

@@ -745,11 +745,6 @@ experimental:
   # If true then control plane computes reachable services automatically based on MeshTrafficPermission.
   # Lack of MeshTrafficPermission is treated as Deny the traffic.
   autoReachableServices: false # ENV: KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES
-  # KDSSyncNameWithHashSuffix if true then during KDS sync resource name is going to be suffixed with hash.
-  # The hash is computed based on various resource characteristics like mesh, namespace, etc. The feature prevents name
-  # collisions when syncing policies with the same names but different meshes from Global(Universal) to Zone(Kubernetes).
-  # More extensive explanation of the problem and solution can be found in the MADR https://github.com/kumahq/kuma/blob/master/docs/madr/decisions/029-kds-sync-hash-suffix.md
-  KDSSyncNameWithHashSuffix: false # ENV: KUMA_EXPERIMENTAL_KDS_SYNC_NAME_WITH_HASH_SUFFIX
 
 proxy:
   gateway:

pkg/config/loader_test.go

@@ -702,7 +702,6 @@ experimental:
     fullResyncInterval: 15s
     delayFullResync: true
   autoReachableServices: true
-  kdsSyncNameWithHashSuffix: true
 proxy:
   gateway:
     globalDownstreamMaxConnections: 1
@@ -968,7 +967,6 @@ tracing:
 				"KUMA_EXPERIMENTAL_KDS_EVENT_BASED_WATCHDOG_FULL_RESYNC_INTERVAL":                          "15s",
 				"KUMA_EXPERIMENTAL_KDS_EVENT_BASED_WATCHDOG_DELAY_FULL_RESYNC":                             "true",
 				"KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES":                                                "true",
-				"KUMA_EXPERIMENTAL_KDS_SYNC_NAME_WITH_HASH_SUFFIX":                                         "true",
 				"KUMA_PROXY_GATEWAY_GLOBAL_DOWNSTREAM_MAX_CONNECTIONS":                                     "1",
 				"KUMA_TRACING_OPENTELEMETRY_ENDPOINT":                                                      "otel-collector:4317",
 				"KUMA_TRACING_OPENTELEMETRY_ENABLED":                                                       "true",

pkg/kds/context/context.go

@@ -67,10 +67,7 @@ func DefaultContext(
 			cfg.Store.Type,
 			cfg.Store.Kubernetes.SystemNamespace,
 		),
-	}
-
-	if cfg.Experimental.KDSSyncNameWithHashSuffix {
-		mappers = append(mappers, AddHashSuffix)
+		AddHashSuffix,
 	}
 
 	return &Context{

pkg/kds/context/context_test.go

@@ -465,8 +465,6 @@ var _ = Describe("Context", func() {
 				cfg.Store.Kubernetes.SystemNamespace = caseCfg.k8sSystemNamespace
 			}
 
-			cfg.Experimental.KDSSyncNameWithHashSuffix = true
-
 			return cfg
 		}
 

test/framework/config.go

@@ -162,8 +162,6 @@ func (c E2eConfig) AutoConfigure() error {
 	Config.Arch = runtime.GOARCH
 	Config.OS = runtime.GOOS
 
-	Config.KumaCpConfig.Multizone.Global.Envs["KUMA_EXPERIMENTAL_KDS_SYNC_NAME_WITH_HASH_SUFFIX"] = "true"
-
 	return nil
 }