Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): enable hash-suffix only if Zone has KDS feature #8460

Merged

Conversation

lobkovilya
Copy link
Contributor

Depends on #8450

It was a mistake to introduce a feature flag for hash-suffixes. We have KDS features, so we can easily check if Zone has a fix to handle MeshGateway renaming.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS -- It will break, I'll handle it in upgrade PR.
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lobkovilya lobkovilya requested a review from a team as a code owner November 27, 2023 10:51
@lobkovilya lobkovilya requested review from jakubdyszkiewicz and lukidzi and removed request for a team November 27, 2023 10:51
@lobkovilya lobkovilya merged commit 20ace49 into kumahq:master Nov 29, 2023
14 checks passed
@lobkovilya lobkovilya deleted the fix/kds-hash-suffix-zone-features branch November 29, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants