-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MeshHTTPRoute): basic MeshGateway support #8402
feat(MeshHTTPRoute): basic MeshGateway support #8402
Conversation
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
d86a110
to
6d79330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MeshHTTPRoute doesn't support kind: MeshGateway
in the top-level targetRef, right? I'm a bit lost, why some policies like MeshTimeout/MeshRetry have kind: MeshGateway
but MeshHTTPRoute uses just kind: MeshService
to target MeshGateway?
Is it going to work if MeshTimeout targets MeshHTTPRoute and MeshHTTPRoute targets MeshGateway? |
Not yet, I need to add that validation to this PR, but ran into #8438. The intention is to support
This is just #6956 not being done |
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
fc2793c
to
01bb43f
Compare
Signed-off-by: Mike Beaumont <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Leaves out the filters and more complex matches for another PR.
This expects routes like:
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --