Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshHTTPRoute): basic MeshGateway support #8402

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 16, 2023

Leaves out the filters and more complex matches for another PR.

This expects routes like:

targetRef:
  kind: MeshGateway
  name: edge
to:
- targetRef:
    kind: Mesh
  rules:
  ...

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Support MeshHTTPRoute/MeshTCPRoutes with MeshGateways #8142
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont force-pushed the feat/gateway-meshhttproute branch from d86a110 to 6d79330 Compare November 16, 2023 20:05
@michaelbeaumont michaelbeaumont marked this pull request as ready for review November 17, 2023 20:03
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 17, 2023 20:03
@michaelbeaumont michaelbeaumont requested review from slonka and lobkovilya and removed request for a team November 17, 2023 20:03
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MeshHTTPRoute doesn't support kind: MeshGateway in the top-level targetRef, right? I'm a bit lost, why some policies like MeshTimeout/MeshRetry have kind: MeshGateway but MeshHTTPRoute uses just kind: MeshService to target MeshGateway?

pkg/xds/envoy/tags/match.go Outdated Show resolved Hide resolved
@lobkovilya
Copy link
Contributor

Is it going to work if MeshTimeout targets MeshHTTPRoute and MeshHTTPRoute targets MeshGateway?

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Nov 22, 2023

MeshHTTPRoute doesn't support kind: MeshGateway in the top-level targetRef, right?

Not yet, I need to add that validation to this PR, but ran into #8438. The intention is to support MeshGateway as well.

I'm a bit lost, why some policies like MeshTimeout/MeshRetry have kind: MeshGateway but MeshHTTPRoute uses just kind: MeshService to target MeshGateway?

This is just #6956 not being done

@slonka slonka requested a review from lobkovilya November 27, 2023 13:50
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway-meshhttproute branch from fc2793c to 01bb43f Compare November 28, 2023 19:57
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont merged commit d16984c into kumahq:master Dec 4, 2023
@michaelbeaumont michaelbeaumont deleted the feat/gateway-meshhttproute branch December 4, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants