Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(xds): route builder #7211

Merged
merged 2 commits into from
Oct 10, 2023
Merged

refactor(xds): route builder #7211

merged 2 commits into from
Oct 10, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jul 8, 2023

This moves the RouteBuilder in the github.com/kumahq/kuma/pkg/xds/envoy/routes package.
Only the reusable Configurers and builders are moved in this package to be reused everywhere the building of a route is need.

This MR is only including the moving into a new package.
Once #7183 is merged and this one is too, I'll create a new MR to replace all envoy config v3 Route definitions with the use of RouteBuilder

Checklist prior to review

@mmorel-35 mmorel-35 requested a review from a team as a code owner July 8, 2023 10:03
@mmorel-35 mmorel-35 requested review from jakubdyszkiewicz and lobkovilya and removed request for a team July 8, 2023 10:03
@slonka
Copy link
Contributor

slonka commented Jul 17, 2023

@lobkovilya or @jakubdyszkiewicz can you take a look at this one when you're online?

@slonka
Copy link
Contributor

slonka commented Oct 5, 2023

@jakubdyszkiewicz or @lobkovilya can you look at this PR when you have some time?

Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Sorry for the long feedback loop on this

@jakubdyszkiewicz jakubdyszkiewicz merged commit 4c067a8 into kumahq:master Oct 10, 2023
@mmorel-35 mmorel-35 deleted the issue-2538/route branch October 10, 2023 17:24
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Oct 11, 2023
slonka added a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants