Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xds): named resources (routes configuration) builders require name #7106

Merged
merged 1 commit into from
Jun 26, 2023
Merged

feat(xds): named resources (routes configuration) builders require name #7106

merged 1 commit into from
Jun 26, 2023

Conversation

mmorel-35
Copy link
Contributor

Defines the route configuration name as a required field for the builder constructor function and adds a validation in the final build function to throw an error if the field is blank.

It also removes the name assignation from common route configuration configurers. It asserts that the name shall be known when the builder is instantiated.

Checklist prior to review

@mmorel-35 mmorel-35 marked this pull request as ready for review June 25, 2023 18:09
@mmorel-35 mmorel-35 requested a review from a team as a code owner June 25, 2023 18:09
@mmorel-35 mmorel-35 requested review from slonka and bartsmykla and removed request for a team June 25, 2023 18:09
@jakubdyszkiewicz jakubdyszkiewicz merged commit c9000fb into kumahq:master Jun 26, 2023
@mmorel-35 mmorel-35 deleted the issue-2538/route branch June 26, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants