Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): increase leader election lease and renew duration (backport of #11796) #12332

Merged
merged 2 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/framework/envs/kubernetes/env.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ func SetupAndGetState() []byte {
)).To(Succeed())

kumaOptions := append([]framework.KumaDeploymentOption{
// Occasionally CP will lose a leader in the E2E test just because of this deadline,
// which does not make sense in such controlled environment (one k3d node, one instance of the CP).
// 100s and 80s are values that we also use in mesh-perf when we put a lot of pressure on the CP.
framework.WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_LEASE_DURATION", "100s"),
framework.WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_RENEW_DEADLINE", "80s"),
framework.WithCtlOpts(map[string]string{
"--experimental-gatewayapi": "true",
}),
Expand Down
10 changes: 10 additions & 0 deletions test/framework/envs/multizone/env.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ func SetupAndGetState() []byte {

kubeZone1Options := append(
[]framework.KumaDeploymentOption{
// Occasionally CP will lose a leader in the E2E test just because of this deadline,
// which does not make sense in such controlled environment (one k3d node, one instance of the CP).
// 100s and 80s are values that we also use in mesh-perf when we put a lot of pressure on the CP.
WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_LEASE_DURATION", "100s"),
WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_RENEW_DEADLINE", "80s"),
WithEnv("KUMA_STORE_UNSAFE_DELETE", "true"),
WithEnv("KUMA_MULTIZONE_ZONE_KDS_NACK_BACKOFF", "1s"),
WithIngress(),
Expand Down Expand Up @@ -93,6 +98,11 @@ func SetupAndGetState() []byte {

kubeZone2Options := append(
[]framework.KumaDeploymentOption{
// Occasionally CP will lose a leader in the E2E test just because of this deadline,
// which does not make sense in such controlled environment (one k3d node, one instance of the CP).
// 100s and 80s are values that we also use in mesh-perf when we put a lot of pressure on the CP.
WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_LEASE_DURATION", "100s"),
WithEnv("KUMA_RUNTIME_KUBERNETES_LEADER_ELECTION_RENEW_DEADLINE", "80s"),
WithEnv("KUMA_MULTIZONE_ZONE_KDS_NACK_BACKOFF", "1s"),
WithIngress(),
WithIngressEnvoyAdminTunnel(),
Expand Down