Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): use MeshService mode and generated hostname (backport of #11832) #11834

Closed
wants to merge 1 commit into from
Closed

test(e2e): use MeshService mode and generated hostname (backport of #11832) #11834

wants to merge 1 commit into from

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Oct 23, 2024

Automatic cherry-pick of #11832 for branch release-2.5

Generated by action

cherry-picked commit 07ac2c7
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.5
Your branch is up to date with 'origin/release-2.5'.

You are currently cherry-picking commit 07ac2c772.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/e2e_env/universal/meshhealthcheck/policy.go

no changes added to commit (use "git add" and/or "git commit -a")

@lukidzi @kumahq
test(e2e): use MeshService mode and generated hostname (#11832)
0ed96b8 
I've noticed a flake of the test

I switched to using MeshService mode instead of manually creating a
MeshService. I'm not sure if MeshService might be removed since the Mesh
has `meshServices.mode` disabled. Additionally, I changed the hostname
to use generated one.

<!-- Is there a MADR? An Issue? A related PR? -->

Fix #XX

<!--
> Changelog: skip
-->
<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

---------

Signed-off-by: Lukasz Dziedziak <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner October 23, 2024 09:44
@kumahq kumahq bot requested review from jakubdyszkiewicz and Automaat and removed request for a team October 23, 2024 09:44
@lukidzi lukidzi closed this Oct 23, 2024
@lahabana lahabana deleted the chore/backport-release-2.5-11832 branch October 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
conflict release-2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukidzi