Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add function mapping Mesh resource to KubeYaml #11448

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Sep 17, 2024

Checklist prior to review

Added option to map resource into kube yaml and changed 2 tests to show it.

  • Link to relevant issue as well as docs and UI issues -- xref: Use resource builders in e2e tests #11294
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lukidzi lukidzi requested a review from a team as a code owner September 17, 2024 16:59
@lukidzi lukidzi requested review from jijiechen and Automaat and removed request for a team September 17, 2024 16:59
@slonka slonka merged commit bc107e6 into kumahq:master Sep 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants