Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resource builders in e2e tests #11294

Open
michaelbeaumont opened this issue Sep 3, 2024 · 4 comments
Open

Use resource builders in e2e tests #11294

michaelbeaumont opened this issue Sep 3, 2024 · 4 comments
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@michaelbeaumont
Copy link
Contributor

Description

We have a lot of static YAMLs and Install functions for various permutations resource fields. We should use the builders we've started using in unit tests.

nit: not the biggest fan of this. We may then need metrics and we'll end up with
MTLSMeshWithMeshServicesAndMetricsKubernetes. I'd do

samples.MeshMTLSBuilder().WithName(meshName).WithEnabledMeshServices("Exclusive").KubeYaml()

Originally posted by @jakubdyszkiewicz in #11279 (comment)
@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code labels Sep 3, 2024
@michaelbeaumont michaelbeaumont mentioned this issue Sep 3, 2024
Merged
6 tasks
@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 9, 2024
@lukidzi lukidzi mentioned this issue Sep 13, 2024
Merged
5 tasks
@slonka
Copy link
Contributor

slonka commented Sep 13, 2024

Please take #11383 (comment) into account when doing this.

@jakubdyszkiewicz jakubdyszkiewicz mentioned this issue Sep 17, 2024
Merged
5 tasks
@lukidzi lukidzi mentioned this issue Sep 17, 2024
Merged
5 tasks
@michaelbeaumont michaelbeaumont mentioned this issue Sep 27, 2024
Merged
5 tasks
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi
Copy link
Contributor

lukidzi commented Dec 16, 2024

I think we started using it recently. Does it address the issue?https://github.com/kumahq/kuma/blob/master/test/e2e_env/kubernetes/meshexternalservice/meshexternalservice.go#L31

@lukidzi lukidzi added triage/pending This issue will be looked at on the next triage meeting and removed triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again labels Dec 16, 2024
@lukidzi
Copy link
Contributor

lukidzi commented Dec 16, 2024

lets check if we still have these methods

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelbeaumont @slonka @lukidzi