Skip to content

Commit

Permalink
fix(e2e): don't reuse namespace for helm upgrade test (#11539)
Browse files Browse the repository at this point in the history
---------

Signed-off-by: Marcin Skalski <[email protected]>
  • Loading branch information
Automaat authored and kumahq[bot] committed Dec 17, 2024
1 parent e8a02b2 commit a963a02
Showing 1 changed file with 32 additions and 0 deletions.
32 changes: 32 additions & 0 deletions test/e2e/helm/kuma_helm_upgrade_multizone.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
)

func UpgradingWithHelmChartMultizone() {
namespace := "helm-upgrade-ns"
var global, zoneK8s, zoneUniversal Cluster
var globalCP ControlPlane

Expand All @@ -39,13 +40,35 @@ func UpgradingWithHelmChartMultizone() {
zoneUniversal = NewUniversalCluster(NewTestingT(), Kuma3, Silent)
})

<<<<<<< HEAD

Check failure on line 43 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

syntax error: unexpected <<, expected }
E2EAfterAll(func() {

Check failure on line 44 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

method has no receiver

Check failure on line 44 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

syntax error: unexpected {, expected name
Expect(zoneUniversal.DismissCluster()).To(Succeed())
Expect(zoneK8s.DeleteNamespace(TestNamespace)).To(Succeed())
Expect(zoneK8s.DeleteKuma()).To(Succeed())
Expect(zoneK8s.DismissCluster()).To(Succeed())
Expect(global.DeleteKuma()).To(Succeed())
Expect(global.DismissCluster()).To(Succeed())
=======

Check failure on line 51 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

syntax error: unexpected ==, expected }
E2EAfterEach(func() {

Check failure on line 52 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

method has no receiver

Check failure on line 52 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

syntax error: unexpected {, expected name
grp := sync.WaitGroup{}
grp.Add(3)
go func() {
defer grp.Done()
Expect(zoneUniversal.DismissCluster()).To(Succeed())
}()
go func() {
defer grp.Done()
Expect(zoneK8s.DeleteNamespace(namespace)).To(Succeed())
Expect(zoneK8s.DeleteKuma()).To(Succeed())
Expect(zoneK8s.DismissCluster()).To(Succeed())
}()
go func() {
defer grp.Done()
Expect(global.DeleteKuma()).To(Succeed())
Expect(global.DismissCluster()).To(Succeed())
}()
grp.Wait()
>>>>>>> 7d80a5ab5 (fix(e2e): don't reuse namespace for helm upgrade test (#11539))

Check failure on line 71 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

syntax error: unexpected >>, expected }

Check failure on line 71 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

newline in rune literal
})

It("should install a Kuma version 2 minor releases behind the current version on Global", func() {

Check failure on line 74 in test/e2e/helm/kuma_helm_upgrade_multizone.go

View workflow job for this annotation

GitHub Actions / check

method has no receiver
Expand Down Expand Up @@ -135,12 +158,21 @@ spec:
}, "30s", "1s").Should(Equal(1))
})

<<<<<<< HEAD
It("should sync DPPs from Zone to Global", func() {
// when start test server on Zone
err := NewClusterSetup().
Install(NamespaceWithSidecarInjection(TestNamespace)).
Install(testserver.Install()).Setup(zoneK8s)
Expect(err).ToNot(HaveOccurred())
=======
By("Sync DPPs from Zone to Global")
// when start test server on Zone
err = NewClusterSetup().
Install(NamespaceWithSidecarInjection(namespace)).
Install(testserver.Install(testserver.WithNamespace(namespace))).Setup(zoneK8s)
Expect(err).ToNot(HaveOccurred())
>>>>>>> 7d80a5ab5 (fix(e2e): don't reuse namespace for helm upgrade test (#11539))

// then the DPP is synced to Global
Eventually(func(g Gomega) int {
Expand Down

0 comments on commit a963a02

Please sign in to comment.