feat(ExternalService): validate same value for service and address (#…

…8641) Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq · Dec 18, 2023 · 3f3f399 · 3f3f399
1 parent ecdbbfc
commit 3f3f399
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/pkg/core/resources/apis/mesh/external_service_validator.go b/pkg/core/resources/apis/mesh/external_service_validator.go
@@ -30,6 +30,12 @@ func (es *ExternalServiceResource) Validate() error {
 		ExtraTagsValidators: []TagsValidatorFunc{validateProtocol},
 	}))
 
+	if service := es.Spec.GetService(); service != "" {
+		if host, _, e := net.SplitHostPort(es.Spec.GetNetworking().GetAddress()); e == nil && service == host {
+			err.AddViolationAt(validators.RootedAt("tags").Key(mesh_proto.ServiceTag), "cannot be the same as networking.address")
+		}
+	}
+
 	return err.OrNil()
 }
 

diff --git a/pkg/core/resources/apis/mesh/external_service_validator_test.go b/pkg/core/resources/apis/mesh/external_service_validator_test.go
@@ -329,5 +329,19 @@ var _ = Describe("ExternalService", func() {
                 - field: networking.tls.clientKey
                   message: data source cannot be empty`,
 		}),
+		Entry("kuma.io/service and networking address clash", testCase{
+			dataplane: `
+                type: ExternalService
+                name: es-1
+                mesh: default
+                networking:
+                  address: httpbin.org:80
+                tags:
+                  kuma.io/service: httpbin.org`,
+			expected: `
+                violations:
+                - field: tags["kuma.io/service"]
+                  message: cannot be the same as networking.address`,
+		}),
 	)
 })