Skip to content

Commit

Permalink
chore(gha): inherit secrets (#12351)
Browse files Browse the repository at this point in the history
## Motivation

`DOCKERHUB_PULL_CREDENTIAL` wasn't propagated

## Implementation information

I suspect it's because of missing secret inherit

## Supporting documentation

<!-- Is there a MADR? An Issue? A related PR? -->

Fix #XX

<!--
> Changelog: skip
-->
<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

Signed-off-by: Lukasz Dziedziak <[email protected]>
  • Loading branch information
lukidzi authored Dec 20, 2024
1 parent 3ea2f55 commit 04182d0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build-test-distribute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ jobs:
matrix: ${{ toJSON(matrix) }}
# can't use env here, make sure change other copies when making changes
runnersByArch: ${{ (github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) && '{"amd64":"ubuntu-latest-kong","arm64":"ubuntu-latest-arm64-kong"}' || '{"amd64":"ubuntu-24.04","arm64":""}' }}
secrets: inherit
test_e2e_env:
needs: ["gen_e2e_matrix"]
if: fromJSON(needs.gen_e2e_matrix.outputs.matrix).test_e2e_env
Expand All @@ -285,3 +286,4 @@ jobs:
matrix: ${{ toJSON(matrix) }}
# can't use env here, make sure change other copies when making changes
runnersByArch: ${{ (github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) && '{"amd64":"ubuntu-latest-kong","arm64":"ubuntu-latest-arm64-kong"}' || '{"amd64":"ubuntu-24.04","arm64":""}' }}
secrets: inherit

0 comments on commit 04182d0

Please sign in to comment.