Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNPM Fix - call ESlint bin command without node #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dndrsn
Copy link

@dndrsn dndrsn commented Mar 21, 2024

The logic that executes the ESlint bin via explicitly using the Node executable does not work on macOS when using PNPM. PNPM creates node_modules/.bin files as shell scripts. Calling them via node will not work. .bin files created by NPM and Yarn are Node scripts but are executable directly without needing to use the Node binary explicitly.

#!/usr/bin/env node

/**
 * @fileoverview Main CLI that is run via the eslint command.
 * @author Nicholas C. Zakas
 */

/* eslint no-console:off -- CLI */

"use strict";
...

As a result it appears that Node does not need to be called explicitly on any platform for any package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant