feat: support dry-run #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poor12
force-pushed
the
support-dry-run
branch
from
892cc32 to
3a14176
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 29.44% 29.57% +0.12%
==========================================
Files 116 118 +2
Lines 13751 13782 +31
==========================================
+ Hits 4049 4076 +27
- Misses 9312 9313 +1
- Partials 390 393 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Poor12
force-pushed
the
support-dry-run
branch
3 times, most recently
from
117f2d7 to
d3b5175
Compare
mrlihanbo
reviewed
Nov 20, 2023
Poor12
force-pushed
the
support-dry-run
branch
2 times, most recently
from
54cadb9 to
71dd767
Compare
gary-lgy
reviewed
Nov 21, 2023
gary-lgy
reviewed
Nov 21, 2023
gary-lgy
reviewed
Nov 21, 2023
gary-lgy
reviewed
Nov 21, 2023
gary-lgy
reviewed
Nov 21, 2023
Poor12
force-pushed
the
support-dry-run
branch
3 times, most recently
from
de8a54b to
ea9a7b8
Compare
gary-lgy
reviewed
Nov 30, 2023
gary-lgy
reviewed
Nov 30, 2023
gary-lgy
reviewed
Nov 30, 2023
gary-lgy
reviewed
Nov 30, 2023
pkg/controllers/statusaggregator/plugins/sourcefeedback/annotations.go
Outdated
Show resolved
Hide resolved
gary-lgy
reviewed
Nov 30, 2023
gary-lgy
reviewed
Nov 30, 2023
pkg/controllers/statusaggregator/plugins/sourcefeedback/annotations_test.go
Outdated
Show resolved
Hide resolved
Poor12
force-pushed
the
support-dry-run
branch
2 times, most recently
from
cc6f904 to
f1b95b5
Compare
|
/cc @gary-lgy |
gary-lgy
reviewed
Dec 1, 2023
pkg/controllers/statusaggregator/plugins/sourcefeedback/annotations_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: shentiecheng <[email protected]>
Poor12
force-pushed
the
support-dry-run
branch
from
f1b95b5 to
a830ed6
Compare
gary-lgy
approved these changes
Dec 1, 2023
miraclejzd
pushed a commit
to miraclejzd/kubeadmiral
that referenced
this pull request
Jan 3, 2024
feat: support dry-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubeadmiral.io/dry-runmeans resource will in the dry run process, will never sync to member clusters.DryRun will only works when workloads have not been propagated to member clusters.
kubeadmiral.io/schedulingis an annotation which indicates the scheduling result.