refactor: replace runtime.Object with metav1.Object in pkg/util/finalizers #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
z1cheng
commented
Nov 17, 2023
z1cheng
changed the title
z1cheng
force-pushed
the
z1cheng/fix_obj_usage
branch
from
4a1df35 to
822ea79
Compare
gary-lgy
reviewed
Nov 21, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 28.87% 28.89% +0.02%
==========================================
Files 114 114
Lines 13590 13545 -45
==========================================
- Hits 3924 3914 -10
+ Misses 9283 9252 -31
+ Partials 383 379 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gary-lgy
reviewed
Nov 21, 2023
gary-lgy
reviewed
Nov 21, 2023
gary-lgy
reviewed
Nov 21, 2023
gary-lgy
reviewed
Nov 21, 2023
|
@z1cheng Could you amend the PR description to remove the |
SOF3
reviewed
Nov 21, 2023
SOF3
approved these changes
Nov 21, 2023
|
Submit a commit to replace the deprecated |
gary-lgy
reviewed
Nov 22, 2023
|
@z1cheng pls rebase the PR (and keep it rebased), address the comment and then LGTM. Don't worry about the codecov/patch check failure. |
z1cheng
force-pushed
the
z1cheng/fix_obj_usage
branch
from
18f4e4c to
26de07c
Compare
SOF3
approved these changes
Nov 23, 2023
gary-lgy
approved these changes
Nov 23, 2023
…izers Signed-off-by: z1cheng <[email protected]>
z1cheng
force-pushed
the
z1cheng/fix_obj_usage
branch
from
26de07c to
94ee52f
Compare
miraclejzd
pushed a commit
to miraclejzd/kubeadmiral
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to replace runtime.Object with metav1.Object in
pkg/util/finalizersrelated to #99