New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(override): add command, args, annotations and labels overrider #264

Merged

mrlihanbo merged 3 commits into kubewharf:main from qclc:add-overriders

Dec 5, 2023

Contributor

qclc commented Nov 10, 2023

No description provided.

qclc force-pushed the add-overriders branch 2 times, most recently from 57a743f to 9bb382e Compare

November 10, 2023 02:43

codecov bot commented Nov 10, 2023 •

edited

Loading

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (53658a1) 29.55% compared to head (c42cd49) 30.21%.

Files	Patch %	Lines
pkg/controllers/override/util.go	40.00%	4 Missing and 8 partials ⚠️
pkg/controllers/override/commandargspatch.go	89.88%	6 Missing and 3 partials ⚠️
pkg/controllers/override/annotationslabelspatch.go	90.16%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   29.55%   30.21%   +0.66%     
==========================================
  Files         118      120       +2     
  Lines       13782    13952     +170     
==========================================
+ Hits         4073     4216     +143     
- Misses       9316     9330      +14     
- Partials      393      406      +13

Flag	Coverage Δ
unittests	`30.21% <84.11%> (+0.66%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qclc force-pushed the add-overriders branch 6 times, most recently from c316731 to 0a0b330 Compare

November 14, 2023 13:40

gary-lgy reviewed

View reviewed changes

pkg/apis/core/v1alpha1/types_overridepolicy.go Outdated Show resolved Hide resolved

gary-lgy reviewed

View reviewed changes

pkg/apis/core/v1alpha1/types_overridepolicy.go Outdated Show resolved Hide resolved

qclc force-pushed the add-overriders branch from 0a0b330 to b89da8b Compare

November 30, 2023 07:53

gary-lgy reviewed

View reviewed changes

pkg/apis/core/v1alpha1/types_overridepolicy.go Outdated Show resolved Hide resolved

gary-lgy reviewed

View reviewed changes

pkg/controllers/override/commandargspatch.go Outdated Show resolved Hide resolved

gary-lgy reviewed

View reviewed changes

pkg/controllers/override/commandargspatch.go Show resolved Hide resolved

gary-lgy reviewed

View reviewed changes

pkg/controllers/override/annotationslabelspatch.go Show resolved Hide resolved

mrlihanbo reviewed

View reviewed changes

pkg/controllers/override/commandargspatch.go Outdated Show resolved Hide resolved

qclc force-pushed the add-overriders branch 5 times, most recently from 0ad685f to 06df456 Compare

December 1, 2023 09:14

qclc added 3 commits

December 1, 2023 17:35


          feat(override): add command,args,annotations and labels overrider

0438e37


          test(override): add unit tests for command and args overrider

ba55822


          test(override): add unit tests for annotations and labels overrider

c42cd49

qclc force-pushed the add-overriders branch from 06df456 to c42cd49 Compare

December 1, 2023 09:35

mrlihanbo approved these changes

View reviewed changes

mrlihanbo merged commit bd2d0f4 into kubewharf:main

7 checks passed

miraclejzd pushed a commit to miraclejzd/kubeadmiral that referenced this pull request


          Merge pull request kubewharf#264 from qclc/add-overriders

a17091c

feat(override): add command, args, annotations and labels overrider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet