🐾 Update to PF5 - part II - onChange event handler #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
reviewed
Jul 16, 2024
| @@ -23,12 +23,19 @@ export const SearchInputProvider: React.FunctionComponent<SearchInputProviderPro | |||
| filterDispatch({ type: 'SET_NAME_FILTER', payload: value }); | |||
| }; | |||
|
|
|||
| const onChange: (event: React.FormEvent<HTMLInputElement>, value: string) => void = ( | |||
| event, | |||
There was a problem hiding this comment.
Suggested change
| event, | |
| _event, |
do you we use the event value ?
yaacov
reviewed
Jul 16, 2024
| event: React.FormEvent<HTMLInputElement>, | ||
| value: string, | ||
| date?: Date, | ||
| ) => void = (event, value) => { |
There was a problem hiding this comment.
Suggested change
| ) => void = (event, value) => { | |
| ) => void = (_event, value) => { |
see other places we get a value we don't use
yaacov
reviewed
Jul 16, 2024
| minute?: number, | ||
| seconds?: number, | ||
| isValid?: boolean, | ||
| ) => void = (event, time, hour, minute) => { |
There was a problem hiding this comment.
Suggested change
| ) => void = (event, time, hour, minute) => { | |
| ) => void = (_event, _time, hour, minute) => { |
There was a problem hiding this comment.
A good catch. Apparently the linter is not shouting on these cases for some reason.
Anyway, I fixed all found places, including ones that I didn't add as part of this PR.
yaacov
reviewed
Jul 16, 2024
| ) => { | ||
| dispatch({ type: 'SET_USERNAME', payload: value }); | ||
| }; | ||
| const onChangePassword: (value: string, event: React.FormEvent<HTMLInputElement>) => void = ( |
There was a problem hiding this comment.
Suggested change
| const onChangePassword: (value: string, event: React.FormEvent<HTMLInputElement>) => void = ( | |
| const onChangePassword: (value: string, event: React.FormEvent<HTMLInputElement>) => void = ( |
adding empty line between the methods
yaacov
reviewed
Jul 16, 2024
| @@ -144,6 +144,17 @@ export const PlansCreateForm = ({ | |||
|
|
|||
| const networkMessages = buildNetworkMessages(t); | |||
| const storageMessages = buildStorageMessages(t); | |||
| const onChangePlan: (value: string, event: React.FormEvent<HTMLInputElement>) => void = ( | |||
There was a problem hiding this comment.
empty line before the methods, here and in L152
yaacov
reviewed
Jul 16, 2024
packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/Hooks/PlanHooks.tsx
Show resolved
Hide resolved
sgratch
force-pushed
the
onChange_event_handler_for_pf5
branch
from
1d0c35d to
5930a24
Compare
Reference: kubev2v#1098 For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function signature) all onChange callback appearances which use parameters. Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
onChange_event_handler_for_pf5
branch
from
5930a24 to
29cb8ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1098
For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function signature) all
onChangecallback appearances which use parameters.