Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: adjust jobs due to v1.30 GA #32456

Merged
merged 1 commit into from
Apr 18, 2024
Merged

CAPI: adjust jobs due to v1.30 GA #32456

merged 1 commit into from
Apr 18, 2024

Conversation

chrischdi
Copy link
Member

Requirements:

  • k8s v1.30 GA release

Step:

Ensure the jobs are adjusted to provide test coverage according to our support policy

Part of kubernetes-sigs/cluster-api#10026

/hold due to waiting for v1.30 GA

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@chrischdi chrischdi mentioned this pull request Apr 17, 2024
Closed
13 tasks
@sbueringer
Copy link
Member

Great stuff (the generation :D)

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@sbueringer
Copy link
Member

/retitle CAPI: adjust jobs due to v1.30 GA

(added hold instead)

@k8s-ci-robot k8s-ci-robot changed the title [WIP] CAPI: adjust jobs due to v1.30 GA CAPI: adjust jobs due to v1.30 GA Apr 17, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@chrischdi
Copy link
Member Author

Should be ready for merge now @sbueringer ?!

@sbueringer
Copy link
Member

I think it's independent of your CAPI PR, but let's wait until that one merges to avoid disruptions

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1cabdf0 into kubernetes:master Apr 18, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@chrischdi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-main-periodics-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-main-periodics-upgrades.yaml
  • key cluster-api-main-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-main-periodics.yaml
  • key cluster-api-main-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-main-presubmits.yaml
  • key cluster-api-prowjob-gen.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-prowjob-gen.yaml
  • key cluster-api-release-1-7-periodics-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-7-periodics-upgrades.yaml
  • key cluster-api-release-1-7-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-7-presubmits.yaml

In response to this:

Requirements:

  • k8s v1.30 GA release

Step:

Ensure the jobs are adjusted to provide test coverage according to our support policy

Part of kubernetes-sigs/cluster-api#10026

/hold due to waiting for v1.30 GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi chrischdi mentioned this pull request Aug 12, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrischdi @k8s-ci-robot @sbueringer