Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump alpha channel with Dec 24 K8s releases #17181

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Bump alpha channel with Dec 24 K8s releases #17181

merged 2 commits into from
Jan 7, 2025
+261 −12

Conversation

hakman
Copy link
Member

@hakman hakman commented Jan 7, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/channels labels Jan 7, 2025
@moshevayner
Copy link
Member

/lgtm
This is new! Do we now need to run hack/generate-asset-hashes.sh every time alpha or stable channels are updated?
Thanks @hakman !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@hakman
Copy link
Member Author

hakman commented Jan 7, 2025 •
edited
Loading

/lgtm This is new! Do we now need to run hack/generate-asset-hashes.sh every time alpha or stable channels are updated? Thanks @hakman !

@moshevayner It's good as we don't need to pull hashes for those artifacts during running. It doesn't break anything not running hack/generate-asset-hashes.sh.

@moshevayner
Copy link
Member

/retest

@hakman
Copy link
Member Author

hakman commented Jan 7, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 77256f8 into kubernetes:master Jan 7, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshevayner moshevayner Awaiting requested review from moshevayner

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@moshevayner moshevayner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @moshevayner @k8s-ci-robot