-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip test `Services should implement NodePort and HealthCheckNodePort… #17172
Conversation
… correctly when ExternalTrafficPolicy changes`
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/retest |
hmm, there are things I do not understand , that issue says is flake but the testgrid shows is permanently failing https://testgrid.k8s.io/kops-network-plugins#kops-aws-cni-cilium The other thing is that it seems that test was not running before that date 🤔 |
the test is failing because the traffic is being masqueraded
|
Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes
started failing for AWS also since Dec 11.https://testgrid.k8s.io/kops-network-plugins#kops-aws-cni-cilium
Ref: kubernetes/kubernetes#129221