Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental limited support for cluster-api #15522

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Experimental limited support for cluster-api #15522

merged 7 commits into from
Feb 29, 2024

Conversation

justinsb
Copy link
Member

Very limited experimental support for cluster-api; we are able to launch GCE VMs into an existing cluster (with some carefully constructed yaml), they can't currently join the cluster or really do anything useful.

  • Minimal cluster-api integration
  • Run go generate in clusterapi
  • make gomod: populate vendor directory
  • Copy some dependencies from cluster-api

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 19, 2023
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab June 19, 2023 17:42
@justinsb justinsb force-pushed the clusterapi branch 2 times, most recently from 0a391f2 to 8e98296 Compare June 19, 2023 17:44
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2023
@hakman hakman mentioned this pull request Oct 2, 2023
Closed
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2023
@k8s-ci-robot k8s-ci-robot added area/documentation area/kops-controller area/nodeup needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 30, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2024
@justinsb justinsb force-pushed the clusterapi branch 6 times, most recently from 999bed2 to 1ee9dae Compare February 28, 2024 17:19
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 28, 2024 •
edited
Loading

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-kubernetes-e2e-ubuntu-gce-build 8e98296 link true /test pull-kops-kubernetes-e2e-ubuntu-gce-build
pull-kops-verify-hashes 71bbf74 link true /test pull-kops-verify-hashes

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Minimal cluster-api integration
ea3122b 
This only barely works, but we can start to boot machines and make
incremental progress.
@justinsb
Copy some dependencies from cluster-api
c1d8fa1 
This lets us use some of the shared schema helpers, without taking a
full dependency on the cluster-api (and all the versions that would
entail).
@justinsb
Run go generate in clusterapi
c3d8a94 
Generate CRDs and deepcopy.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 701adb6 into kubernetes:master Feb 29, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 29, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/kops-controller area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @hakman