-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dual Stack Public ECR endpoint support #1070
base: master
Are you sure you want to change the base?
Add Dual Stack Public ECR endpoint support #1070
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @BDworak. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
98f70b1
to
af88b57
Compare
/ok-to-test |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the dual stack ECR endpoint
ecr-public.aws.com
to ecr-credential-provider so that it can provide authorization for the public registry. Tests updated to test both possible variants of this change.Special notes for your reviewer:
Related to:
#1069
awslabs/amazon-eks-ami#2082
Does this PR introduce a user-facing change?:
NONE