Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update KubeVirt quickstart guide #11734

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nunnatsa
Copy link
Contributor

What this PR does / why we need it:

The KubeVirt sections in the quickstart guide are a bit old, and are not working as expected, as result of changes in several components.

This PR updates the old KubeVirt sections, to a working instructions. In addition, the guide now presents all the supported boot images.

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2025
@nunnatsa nunnatsa changed the title Update KubeVirt quickstart guide 📖 Update KubeVirt quickstart guide Jan 22, 2025
@sbueringer
Copy link
Member

sbueringer commented Jan 22, 2025

Would be good if a maintainer of the kubevirt provider can do a review

EDIT: Just saw your comment on the other PR :). In general would be just good to have a review from someone additional that is familiar with the topic. I can then take a final look and merge :)

Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nunnatsa. Left some comments.

docs/book/src/user/quick-start.md Show resolved Hide resolved
docs/book/src/user/quick-start.md Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
The KubeVirt sections in the quickstart guide are a bit old, and are
not working as expected, as result of changes in several components.

This PR updates the old KubeVirt sections, to a working instructions. In
addition, the guide now presents all the supported boot images.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants