Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Release v1.9.0 #11554

Merged

Conversation

chandankumar4
Copy link
Contributor

What this PR does / why we need it:

  • Release notes for v1.9.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of: #11092

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 10, 2024
- Metrics: Revert "Add nilIsZero to all KSM metric configs where needed" (#11107)
- ClusterClass/MachinePool: Remove paused handling from reconcileExternal (#11400)
- KCP/MachineSet: Implement KCP and MS Deleting conditions (#11381)
- Machine/KCP]: Implement grace period for KCP remote conditions (#11339)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "]"

Suggested change
- Machine/KCP]: Implement grace period for KCP remote conditions (#11339)
- Machine/KCP: Implement grace period for KCP remote conditions (#11339)

Copy link
Contributor Author

@chandankumar4 chandankumar4 Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh! might be it got left while updating, thanks for pointing

@chrischdi
Copy link
Member

lgtm except sunnat's finding.

@Sunnatillo
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@chrischdi
Copy link
Member

/approve

Pending typo

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
Signed-off-by: chandankumar4 <[email protected]>
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 299c359936ce8ab130f184f79d93456f475e3d85

@Sunnatillo
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6b05964 into kubernetes-sigs:main Dec 10, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Dec 10, 2024
@Sunnatillo Sunnatillo mentioned this pull request Dec 12, 2024
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants