-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Release v1.9.0 #11554
🚀 Release v1.9.0 #11554
Conversation
dff52cd
to
8ebf391
Compare
CHANGELOG/v1.9.0.md
Outdated
- Metrics: Revert "Add nilIsZero to all KSM metric configs where needed" (#11107) | ||
- ClusterClass/MachinePool: Remove paused handling from reconcileExternal (#11400) | ||
- KCP/MachineSet: Implement KCP and MS Deleting conditions (#11381) | ||
- Machine/KCP]: Implement grace period for KCP remote conditions (#11339) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove "]"
- Machine/KCP]: Implement grace period for KCP remote conditions (#11339) | |
- Machine/KCP: Implement grace period for KCP remote conditions (#11339) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh! might be it got left while updating, thanks for pointing
lgtm except sunnat's finding. |
/hold |
/approve Pending typo |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chandankumar4 <[email protected]>
8ebf391
to
8933c2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 299c359936ce8ab130f184f79d93456f475e3d85
|
/unhold |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of: #11092
/area release